cacti icon indicating copy to clipboard operation
cacti copied to clipboard

docs(devcontainer): add trivy and its VSCode Extension

Open ashnashahgrover opened this issue 1 year ago • 2 comments

Commit to be reviewed


docs(devcontainer): add trivy and its VSCode Extension

Primary Changes
----------------
1) updated trivy version in the .devcontainer file and included trivy vs-code extension
2) updated trivy version in ci.yaml

Changes required to incorporate 1)
--------------------------------------
3) included trivy vs-code extension in the .vscode/extensions.json file

Fixes #2650

Pull Request Requirements

  • [ ] Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • [ ] Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • [ ] Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • [ ] Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • [ ] Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners For rebasing and squashing, here's a must read guide for beginners.

ashnashahgrover avatar Jun 11 '24 08:06 ashnashahgrover

@ashnashahgrover Are you still working on this? If not, we can close it down and pick it back up later. I'm trying to keep the PR queue fresh.

petermetz avatar Jul 03 '24 23:07 petermetz

@ashnashahgrover please read the PR message again (and similarly, commit message)

TheJagpreet avatar Jul 23 '24 03:07 TheJagpreet

@ashnashahgrover Seems like a rebase gone wrong type of situation. Please remove the non-relevant lines from the diff.

@petermetz I deleted the non-relevant lines, please let me know if you still see any issues.

ashnashahgrover avatar Aug 05 '24 03:08 ashnashahgrover

@ashnashahgrover are you still working on this? If yes please rebase with latest main and address the other comments please.

@RafaelAPB, all changes have been addressed can you re review?

ashnashahgrover avatar Aug 29 '24 21:08 ashnashahgrover