cacti icon indicating copy to clipboard operation
cacti copied to clipboard

test(ethereum): refactor jest test negative test cases

Open ashnashahgrover opened this issue 1 year ago • 2 comments

Commit to be reviewed

test(ethereum): refactor jest test negative test cases

Primary Changes
---------------
1. Refactored negative test case exception assertions for cactus-plugin-ledger-connector-ethereum.
Removed try-catch blocks, replaced with declarations through jest-extended's own API.
2. Made comments on specific tests where the tests should fail but are actually passing 
and thus cannot be refactored before being investigated further. 

Fixes #3475

Pull Request Requirements

  • [ ] Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • [ ] Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • [ ] Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • [ ] Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • [ ] Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners For rebasing and squashing, here's a must read guide for beginners.

ashnashahgrover avatar Aug 12 '24 19:08 ashnashahgrover

@ashnashahgrover Please fix the lint check and then we are good to merge

petermetz avatar Aug 27 '24 07:08 petermetz

@ashnashahgrover Please fix the lint check and then we are good to merge

This is done @petermetz

ashnashahgrover avatar Sep 03 '24 00:09 ashnashahgrover

Closing this due to inactivity. Happy to reopen it anytime in the future as needed.

petermetz avatar Oct 15 '24 00:10 petermetz