Arvind Bright comments

Results 168 comments of


                                            Arvind Bright

XDS Ring Hash inconsistent after client and server restarts

I feel like I have found what the issue could be. I have pushed some more commits to https://github.com/arvindbr8/grpc-go/tree/dbug_6927. This contains a potential fix and other debug messages (which would...

deps: move from github.com/golang/protobuf to google.golang.org/protobuf/proto

@Clement-Jean -- friendly ping here, didnt want the bot to mark this stale

deps: move from github.com/golang/protobuf to google.golang.org/protobuf/proto

Apologies for the delay -- @Clement-Jean. I have been busy with some internal priorities. Taking a look now.

deps: move from github.com/golang/protobuf to google.golang.org/protobuf/proto

Also it is weird that I'm not able to see your reply on my comment. however there was a email notification for it > Do you mean removing the switch...

deps: move from github.com/golang/protobuf to google.golang.org/protobuf/proto

Ah I see.. I would prefer if we could decouple those changes. You can ignore my comment there. I will track that suggestion in Doug's PR.

deps: move from github.com/golang/protobuf to google.golang.org/protobuf/proto

Approved. Thanks for the PR. We need 1 more person from the team to take a look at it.

fix enabling compression by trimming whitespaces in accept encoding header

LGTM. Thanks for the PR @sercand

channelz: major cleanup / reorganization

I discussed with @dfawley offline. The general refactor and the changes look good to me. There is however still more scope of cleanup - which can be categorized as future...

channelz: major cleanup / reorganization

I've resolved the convos for nits. Could you take a look at the rest and see if makes sense?

stats: peer is not populated for all HandleRPC client callbacks

@aranjans -- Ping; This might something to look at after issue you are currently looking at.