deps: move from github.com/golang/protobuf to google.golang.org/protobuf/proto

[Clement-Jean]

@dfawley this is the continuation of #6919

I'm still unsure about the reflection package. I read the README there and it says that we shouldn't regenerate the testv3.go file. I see two solutions, either we manually edit the generated file (this was previously done) or we regenerate with an older version of protoc. What do you think?

[codecov[bot]]

Codecov Report

Merging #6961 (803dee9) into master (8d735f0) will decrease coverage by 1.38%. Report is 28 commits behind head on master. The diff coverage is 90.00%.

:exclamation: Current head 803dee9 differs from pull request most recent head f8b66b5. Consider uploading reports for the commit f8b66b5 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #6961      +/-   ##
==========================================
- Coverage   83.71%   82.34%   -1.38%     
==========================================
  Files         287      296       +9     
  Lines       30926    31471     +545     
==========================================
+ Hits        25889    25914      +25     
- Misses       3972     4487     +515     
- Partials     1065     1070       +5     

Files	Coverage Δ
credentials/credentials.go	87.87% <ø> (ø)
internal/pretty/pretty.go	91.66% <100.00%> (+49.56%)	:arrow_up:
xds/internal/xdsclient/bootstrap/bootstrap.go	74.48% <33.33%> (ø)

... and 38 files with indirect coverage changes

[dfawley]

I'm still unsure about the reflection package. I read the README there and it says that we shouldn't regenerate the testv3.go file. I see two solutions, either we manually edit the generated file (this was previously done) or we regenerate with an older version of protoc. What do you think?

I don't believe this should be changed. It tests that we will work with old generated code; we'd like to still confirm that fact in our tests.

[github-actions[bot]]

This PR is labeled as requiring an update from the reporter, and no update has been received after 6 days. If no update is provided in the next 7 days, this issue will be automatically closed.

[arvindbr8]

@Clement-Jean -- friendly ping here, didnt want the bot to mark this stale

[Clement-Jean]

@arvindbr8 could you take a look at the comment on your suggestions? Not entirely sure about how to proceed

[arvindbr8]

Apologies for the delay -- @Clement-Jean. I have been busy with some internal priorities. Taking a look now.

[arvindbr8]

Also it is weird that I'm not able to see your reply on my comment. however there was a email notification for it

Do you mean removing the switch and receive a proto.message as ToJSON argument?

you can ignore this comment. That was only a nit to combine the logic in the both the switch cases. Im not too inclined for it

Please let me know if you have other questions.

[Clement-Jean]

@arvindbr8 so basically right now we are blocked at this point. We need to wait for @dfawley rewrite of channelz. Once this is done, we can go further and do the change in credentials/credentials.go that you suggested.

[arvindbr8]

Ah I see.. I would prefer if we could decouple those changes. You can ignore my comment there. I will track that suggestion in Doug's PR.

[arvindbr8]

Approved. Thanks for the PR. We need 1 more person from the team to take a look at it.

[dfawley]

Thanks for the PR! I went ahead and made some minor cleanup edits to speed things up; hope that's okay. :)