Arvind Bright comments

Results 168 comments of


                                            Arvind Bright

test: add test for invalid streamID

@AnandInguva - Sure, taking a look

move from github.com/golang/protobuf to google.golang.org/protobuf/proto

A few comments @Clement-Jean -- PTAL. While you are taking a look, could you also look at the merge conflict?

When handle unary grpc requests, it seems End-of-Stream is not neccesary, why?

> the go-grpc server don't rely on End-of-Stream to mark the end of a request. This is only true in the case of Unary RPCs. EOS flag only marks the...

When handle unary grpc requests, it seems End-of-Stream is not neccesary, why?

Thanks for clarifying @dfawley. @rinfx FYI this is the protocol doc that is up to date - https://github.com/grpc/grpc/blob/master/doc/PROTOCOL-HTTP2.md

DNS resolving with timeout

@and1truong -- let us know if this is ready for another review

DNS resolving with timeout

okay, I'll request @dfawley to take another look at this

DNS resolving with timeout

Thanks for the PR @and1truong. We look forward to seeing your next PR.

ALPN implementation needed in Client side

I need to get some context on the original issue. Let me take a look at it and get back to you

ALPN implementation needed in Client side

Let's track this now in #434 and finalize what needs to be done. We can reopen if this is potentially a fix that is required.

xds: security configuration needs to be per cluster, not from the top level cluster

https://github.com/grpc/proposal/pull/404 is merged. This is unblocked now.