Arvind Bright comments

Results 168 comments of


                                            Arvind Bright

internal/xdsclient: xdsclient transport logs should indicate the authority

I dont think adding another prefix to our prefix logger would be the right way to go. Let me clone your repo and check the type error from my side.

internal/xdsclient: xdsclient transport logs should indicate the authority

Hi @my4-dev, Could you check [this diff out](https://github.com/grpc/grpc-go/compare/master...arvindbr8:grpc-go:6091?expand=1). My idea to implement this would be along this diff. On a high level, the logger that is passed to authority.go and...

Flaky test: Data race in test in xdsclient package

https://github.com/grpc/grpc-go/actions/runs/4737949866/jobs/8411283971?pr=6214

Flaky test: Data race in test in xdsclient package

https://github.com/grpc/grpc-go/actions/runs/5050674448/jobs/9061667273?pr=6307. seems like a related issue.

test/keepalive: Improve TestKeepaliveClientClosesWithActiveStreams

Hey @tobotg Test/DialWaitsForServerSettingsAndFails and Test/FullHandshake are not known flakes. I've triggered a re-run. lets see how that goes.

test/keepalive: Improve TestKeepaliveClientClosesWithActiveStreams

Hey @tobotg, thanks for the revision. I will take a look at it shortly.

test/keepalive: Improve TestKeepaliveClientClosesWithActiveStreams

thanks @tobotg, Changes looks better now. A few minor comments and nits. Please take a look and let us know.

test/keepalive: Improve TestKeepaliveClientClosesWithActiveStreams

@tobotg, Please let us know when you want us to take another look at this.

Improve `regenerate.sh` to use the correct proto compiler version

@avinilcodes -- friendly ping

internal/credentials/xds: add unit test for HandshakeInfo.Equal

@zedGGs -- Thanks for your interest. But it seems like we have a PR in flight. I'm more than happy to reserve this to you until we have merged that...