Arvind Bright comments

Results 168 comments of


                                            Arvind Bright

Flaky test: 6/100K: Test/LRSClient

https://github.com/grpc/grpc-go/actions/runs/10522810801/job/29156226731?pr=7554

transport: handler server transport continuously reads from streams without waiting for application

We can pick this up during a fixit in the coming Qs. We should definitely be able to come up with a plan to resolve this.

transport: add missing tests for http2_client

We should reassess this PR by looking at the coverage report for the file here: https://app.codecov.io/gh/grpc/grpc-go/blob/master/internal%2Ftransport%2Fhttp2_client.go

.*: fix revive lints `redefines-builtin-id`

We should have probably rebased and removed [this](https://github.com/grpc/grpc-go/blob/master/scripts/revive.toml#L31) TODO.

xds: switching to stubserver in tests instead of testservice implementation

@janardhankrishna-sai -- Also please mention the PR description why does this diff "partially" fix the issue. The last few comments in https://github.com/grpc/grpc-go/issues/7291 is also not very clear.

Add godoc linter

#7577 fixes: 546 unused-parameter (ignored) and renamed the check again cc: @purnesh42H

Add godoc linter

Adding this here for context: > https://github.com/grpc/grpc-go/pull/7552#issuecomment-2327328750 Based on the discussion, we have sufficient cases where having an empty block is justifiable, so it's reasonable to include an "empty-block" check...

protoc-gen-go-grpc: add period to end of generated comment

> @arvindbr8 is the vet issue fixed? Do we have to regenerate the protos again? Not very important, but relevant for this PR. This https://github.com/grpc/grpc-go/pull/7351 introduce support for editions. However...