Arvind Bright comments

Results 168 comments of


                                            Arvind Bright

Flaky test package: test/xds

another one for TestServerSideXDS_WithValidAndInvalidSecurityConfiguration: https://github.com/grpc/grpc-go/actions/runs/7480796959/job/20361025267?pr=6916

Flaky test package: test/xds

https://github.com/grpc/grpc-go/actions/runs/7716359885/job/21032969470?pr=6949

Flaky test package: test/xds

https://github.com/grpc/grpc-go/actions/runs/7791646589/job/21248143511?pr=6965

Adding protoc gen go grpc tests

Thanks for sending us this PR @zedGGs. At a high level, we want to be testing the `protoc-gen-go-grpc` binary and not really unit test the behavior of `generateFile()`. There are...

Adding protoc gen go grpc tests

@zedGGs -- I guess your changes were not pushed to your branch? Please take a look

Adding protoc gen go grpc tests

Since @dfawley has more context I'll reassign it to him

Adding protoc gen go grpc tests

@zedGGs - I would be cautious when I do a force push to your branch. Github UI handles that weirdly and sometimes have gotten rid of the previous conversations on...

Adding protoc gen go grpc tests

Since this PR is going stale, I decided to open https://github.com/grpc/grpc-go/pull/7072 to attempt to fix it.

Adding protoc gen go grpc tests

Sorry about that @zedGGs. Please feel free to take up another issue in the repo. We would love to take a look at your PR.

XDS Ring Hash inconsistent after client and server restarts

@k-raval -- We appreciate your patience here. Just taking a bit to come up to context with xDS Ring Hash consistencies. Will get back to you asap.