grpc-go icon indicating copy to clipboard operation
grpc-go copied to clipboard
Published 2 weeks ago • verified publisher icon grpc

transport: add missing tests for http2_client

Open hanut19 opened this issue 1 year ago • 5 comments

Fix for: https://github.com/grpc/grpc-go/issues/2248

RELEASE NOTES: None

hanut19 avatar Jul 31 '24 07:07 hanut19

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: hanut19 (52b87e0a727afeb01007b1f30a012bb7ebe97983, a1709988878c3de371b21dcd52a5ba41d5facbf0, 73f07136b51b58000463aaf458aed4f0de3e4112, cbb5e48d88e323c1a82228dbea0325a493d5e2e2, b2c5b17461dfb8aba07bd3d93aec8c920d5748c7, a238114e63cf5ee9c4d606ed286c48794448b319, 1ce329baa600c2f1578d1efe917b473b1e4b6429, a3cae7f9624ab687177276ca1bc6a6cca13b0b16, ff7775c49a40012fed124c7841660ef9bc83b625, a5840e7b4336e6beec99e4c8b3596fa448683c28, 6da45fe1ce975b8c42b93918ae8268c26328b408, 4b359674573313b0b3d2ebeaa621683a671eca1b, 9c6b4ef7b234c10363774223daf2948f5b291a49, c78509c06e81bce183ecdbb8328dc477f9a09d98, e29fb42102c864b2757474954e47e4409eba1b10, a639be843d1c21e446f3435e723511b7930c6011, f122c9735a67272acd84c78ba473165e169cd83b, 3b80f789fe61269b5614cd97beee7cb52b6c0873, 3d812711784f9051068ac657f4747af1753487ba)

linux-foundation-easycla[bot] avatar Jul 31 '24 07:07 linux-foundation-easycla[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.92%. Comparing base (00514a7) to head (52b87e0).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7462      +/-   ##
==========================================
+ Coverage   81.73%   81.92%   +0.19%     
==========================================
  Files         361      361              
  Lines       27809    27809              
==========================================
+ Hits        22730    22783      +53     
+ Misses       3869     3837      -32     
+ Partials     1210     1189      -21

see 25 files with indirect coverage changes

codecov[bot] avatar Jul 31 '24 07:07 codecov[bot]

Please modify the test cases mock conn’s to throw error only in case of test condition being true like client preface

purnesh42H avatar Aug 09 '24 06:08 purnesh42H

@purnesh42H comment added. please check

hanut19 avatar Aug 26 '24 08:08 hanut19

@arvindbr8 adding you for one more review. Thanks!

purnesh42H avatar Aug 27 '24 12:08 purnesh42H

We should reassess this PR by looking at the coverage report for the file here: https://app.codecov.io/gh/grpc/grpc-go/blob/master/internal%2Ftransport%2Fhttp2_client.go

arvindbr8 avatar Aug 29 '24 20:08 arvindbr8

Closing this PR as we need to revisit the approach

purnesh42H avatar Sep 03 '24 05:09 purnesh42H