Arvind Bright
Arvind Bright
@jroper -- thanks for the clarification. You are right, gRPC-Go does not check for `ConnectionState.NegotiatedProtocol` and err if nil @prakrit55 -- Sure you can pick this up. Let me assign...
@prakrit55 -- this is potentially a breaking change for some existing users. The change needs to be carefully rolled out. Let's have the implementation flag protected using an env variable...
Thanks for your PR @Hrily -- but this issue might be easier for someone on our team to pick up. But if you managed to get the probe test description...
https://github.com/grpc/grpc-go/actions/runs/9996172593/job/27629932247?pr=7397
Run on M2 macbook @master (1.59.0-dev).. So the results below are not comparable. -------- Ran it again to see what the diff is since the last comment ``` $ go...
This should be fixed in this release: https://github.com/grpc/grpc-go/releases/tag/cmd%2Fprotoc-gen-go-grpc%2Fv1.4.0
Released as part of https://github.com/grpc/grpc-go/releases/tag/cmd/protoc-gen-go-grpc/v1.5.x
> From the documentation of resolver.AddressMap, it sounds like resolver.BalancerAttribute should always be ignored, and two addresses with all fields equal except for resolver.BalancerAttribute and Metadata have the same key....
> Testing / tests (tests, 1.22, 386) (pull_request) Something is wrong with this presubmit check. Will need to investigate. Merging since this change is not expected to break 386 variant...
Feel free to send us a PR if you need this. I would consider missing features not bugs :)