grpc-go icon indicating copy to clipboard operation
grpc-go copied to clipboard

xds: switching to stubserver in tests instead of testservice implementation

Open janardhanvissa opened this issue 1 year ago • 1 comments

Partially Addresses: https://github.com/grpc/grpc-go/issues/7291

RELEASE NOTES: None

janardhanvissa avatar Oct 10 '24 11:10 janardhanvissa

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.66%. Comparing base (d66fc3a) to head (e5a21ea). Report is 22 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7726      +/-   ##
==========================================
- Coverage   81.71%   81.66%   -0.05%     
==========================================
  Files         374      374              
  Lines       38166    37978     -188     
==========================================
- Hits        31188    31016     -172     
+ Misses       5699     5643      -56     
- Partials     1279     1319      +40     

see 52 files with indirect coverage changes

codecov[bot] avatar Oct 10 '24 11:10 codecov[bot]

@easwars for second review

purnesh42H avatar Oct 29 '24 06:10 purnesh42H

@janardhankrishna-sai -- Also please mention the PR description why does this diff "partially" fix the issue. The last few comments in https://github.com/grpc/grpc-go/issues/7291 is also not very clear.

arvindbr8 avatar Oct 29 '24 18:10 arvindbr8

@janardhankrishna-sai -- Also please mention the PR description why does this diff "partially" fix the issue. The last few comments in #7291 is also not very clear.

janardhanvissa avatar Nov 07 '24 17:11 janardhanvissa