grpc-go icon indicating copy to clipboard operation
grpc-go copied to clipboard

Retry: grpc maxretry attempts is hardcoded

Open Leomax004 opened this issue 4 years ago • 3 comments
trafficstars

Grpc Max Retry attempt is hardcoded and not allowing to retry more than 5

if rp.MaxAttempts > 5 { // TODO(retry): Make the max maxAttempts configurable. rp.MaxAttempts = 5 }

Leomax004 avatar Jul 23 '21 18:07 Leomax004

Reference from gRFC:

https://github.com/grpc/proposal/blob/master/A6-client-retries.md#limits-on-retries-and-hedges

We never implemented this particular "channel arg" in Go.

dfawley avatar Aug 04 '21 17:08 dfawley

How is this a feature and not a bug? This makes the whole retry config pretty much unusable. And it's not even mentioned in the documentation!

gnvk avatar Feb 21 '24 09:02 gnvk

Feel free to send us a PR if you need this. I would consider missing features not bugs :)

arvindbr8 avatar Feb 28 '24 18:02 arvindbr8