grpc-go icon indicating copy to clipboard operation
grpc-go copied to clipboard

Please release upgrade /cmd/protoc-gen-go-grpc /go.mod to security fixed protobuf v1.33.0

Open edcrewe opened this issue 1 year ago • 2 comments
trafficstars

Please upgrade go.mod

See https://github.com/grpc/grpc-go/blob/cmd/protoc-gen-go-grpc/v1.3.0/cmd/protoc-gen-go-grpc/go.mod Security issue with

require google.golang.org/protobuf v1.28.1

google.golang.org/protobuf │ CVE-2024-24786 │ MEDIUM │ fixed │ v1.28.1 │ 1.33.0 │ golang-protobuf: encoding/protojson, internal/encoding/json: │ infinite loop in protojson.Unmarshal when unmarshaling certain forms of... https://avd.aquasec.com/nvd/cve-2024-24786

upgrade to

require google.golang.org/protobuf v1.33.0

(ideally upgrade to a more recent go version than 1.17 whilst you are at it!)

edcrewe avatar Apr 04 '24 08:04 edcrewe

Sorry we realized you have already done this work, it is just waiting for a new release version for the changes at https://github.com/grpc/grpc-go/blob/master/cmd/protoc-gen-go-grpc/main.go

edcrewe avatar Apr 04 '24 11:04 edcrewe

I'd like to wait on #7057 before doing the next release if possible, which might be a couple weeks.

dfawley avatar Apr 04 '24 15:04 dfawley

@dfawley @arvindbr8 Any chance we could get a new release now? We'd like to take advantage of #7243.

rittneje avatar May 23 '24 10:05 rittneje

Yes, this is on our radar, we will try to get it done this week or next.

dfawley avatar May 23 '24 14:05 dfawley

This should be fixed in this release: https://github.com/grpc/grpc-go/releases/tag/cmd%2Fprotoc-gen-go-grpc%2Fv1.4.0

arvindbr8 avatar Jun 04 '24 16:06 arvindbr8