Andy Waite comments

Results 394 comments of


                                            Andy Waite

Introduce `.ruby-lsp.yml` config file

(looks like some tests need a slightl adjustment for Windows)

Introduce `.ruby-lsp.yml` config file

TODO: update `ruby-lsp-doctor` to handle new config

Introduce `.ruby-lsp.yml` config file

(re-opening for now but really we should create a seperate issue/PR for @vinistock's [suggestion](https://github.com/Shopify/ruby-lsp/pull/1434#issuecomment-2018723331)).

Introduce `.ruby-lsp.yml` config file

Closing since we are planning a different approach: https://github.com/Shopify/ruby-lsp/issues/2156

Implement ASDF as a manager object

ASDF also supports `.ruby-version`, will that work here?

Implement ASDF as a manager object

I use asdf on my personal machine so can try this later.

Matching for `excluded_patterns` in `.index.yml`

@vinistock @st0012 this seems like a bug, right? (I know we're planning to eliminate the config file, but this would likely also apply to the config settings approach)

Matching for `excluded_patterns` in `.index.yml`

Note: Even though we are deprecating `.index.yml` this may still be an issue for the indexing configuration.

Investigate disabling `BUNDLE_BIN` automatically

Let's review the others too: https://bundler.io/v2.5/man/bundle-config.1.html#LIST-OF-AVAILABLE-KEYS (perhaps it may be safe to filter on a set that we _do_ allow).

[Draft] Add jruby to CI

Thank you, it seems this related to the [patch](https://github.com/Shopify/ruby-lsp/blob/main/lib/core_ext/uri.rb) we have for `URI::Generic.from_path`. As Sorbet [does not officially support](https://github.com/sorbet/sorbet/blob/master/docs/JRuby.md) JRuby, this may be a difficult one to solve...