Andy Waite

I looked to see how the Lua extension handles this, since it also has `end`, but it's a different approach. It's based on `textDocument/publishDiagnostics`. So after you type `if true...

This likely relates to `more_trigger_character`: https://github.com/Shopify/ruby-lsp/blob/f3ff6a36afbc7134d640c8e6be54c7c8f63f0aaf/lib/ruby_lsp/requests/on_type_formatting.rb#L15 Mentioned here (`moreTriggerCharacter`) in the spec: https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocument_onTypeFormatting

I'd suggest calling this "Pull Up Method" to match the naming in https://refactoring.com/catalog/

@rogancodes for now, just use your judgement to pick a name, we can easily change it before merging. (I would argue that it _shouldn't_ use the term 'refactor', since we...

Similar to what @st0012 mentioned, it is a bit awkward that we'll be showing these commands for non-Rails codebases, especially if we add more Rails commands in future. I'm looking...

When generate a `resource`, it fails at the file opening stage for one file, I suspect the output parsing needs little adjustment: > cannot open file:///Users/andyw8/src/github.com/Shopify/ruby-lsp-rails/app/views/widgets. Detail: Unable to read...

I _thought_ that if you try run a generator where some files already exist, Rails would interactively prompt to ask whether to overwrite each file, but I can't seem to...

> > When generate a resource, it fails at the file opening stage for one file, I suspect the output parsing needs little adjustment: > > Fixed it! Thanks for...

It might be worth checking what other language servers do, but I suspect we _shouldn't_ be matching on instance variables in other contexts, since they may be named co-incidentally, whereas...

Another thing we could do, especially for the benefit of tests, is to match on a type name followed by a number, e.g. `product_1`.