Andy Waite comments

Results 394 comments of


                                            Andy Waite

Running rails tests in the vscode test explorer is quite slow

Hi @andypeters, this is a known limitation, there is some work happening here to try improve it: https://github.com/Shopify/ruby-lsp/pull/2230 (I moved the issue to `ruby-lsp-rails`, but I'm going to move it...

Add note about Mise version manager

I've updated it to point to the Mise docs instead. I think the locality of the advice is important - people tend to skim docs, so having this next to...

Properly handle methods for definition, completion and hover

It's not usable yet, but a first step towards this was merged today: https://github.com/Shopify/ruby-lsp/pull/1043

Properly handle methods for definition, completion and hover

It could be helpful to add a checklist to the PR description here indicating what's remaining.

Improve Rails app detection

There is some corresponding discussion happening in https://github.com/Shopify/ruby-lsp-rails/pull/284 about what is the right approach for this.

Improve Rails app detection

Handled by https://github.com/Shopify/ruby-lsp-rails/pull/284

Parse RBS overloads into signatures

(have moved the Ruby LSP changes out to `andyw8/support-multiple-signatures`)

Parse RBS overloads into signatures

@soutaro this is still WIP, but thought you may be interested to see our approach.

Parse RBS overloads into signatures

There's one thing I need to fix but I'd like to start getting reviews on this.

Relative constants from included modules are predicted as absolute references

Verified as reproducible on the latest release.