Andy Waite comments

Results 394 comments of


                                            Andy Waite

Nice. https://github.com/presidentbeef/ruby-lsp-brakeman

So we'd avoid the `identifier` key, and do this? ``` "rubyLsp.rubyVersionManager": { "chruby": { "foo": "bar" } } ```

Worth adding an ERB fixture just for ease of tophatting?

(it might just involve some extra checks for https://rubyapi-org.statuspage.io)

As per the team discussion earlier today, we will move ahead with using RBS declarations for indexing core class (String, Integer, etc).

I've updated the description with tasks related to RBS.

That would be great.

It was copied from https://github.com/threedaymonk/htmlbeautifier/issues/78#issuecomment-2369219951 but I haven't yet looked into it.

Let's add this to the roadmap: https://github.com/Shopify/ruby-lsp/pull/2950

Seems a reasonable approach 👍