Andy Waite

Results 394 comments of Andy Waite

@bibstha since these instructions aren't specific to VS Code, we should add them to the main README instead. I'd suggest adding a new section, e.g. 'Formatting and Linting'. Once added,...

Hi @bibstha, are you able to continue on this? After discussing with @vinistock, we think it could be better to have an explicit statement like “Using globally installed formatters or...

Thanks for the report. We're using `Shellwords.escape` but this is intended for the Bourne shell, so probably isn't a valid approach for Windows. We'll need to look into that.

@Super-Xray Can you try this branch please? https://github.com/Shopify/ruby-lsp/pull/2109

Similarly, this also happens if you use `bundle gem` when creating a new gem, since there's initially no `Gemfile.lock`.

:wave: Thanks for the report, I am able to reproduce.

Observations: - By default, when we make a change to a file, a `textDocument/diagnostic` is sent. - With `rubyLsp.pullDiagnosticsOn` set to `save`, and we use "Save Without Formatting", there is...

@vassyz those settings are for a different extension, https://github.com/Shopify/vscode-ruby-lsp

> And for some reason the addon's error reporting mechanism didn't work as expected as the error message is not displayed. This should be solved by https://github.com/Shopify/ruby-lsp/pull/2085

@searls You probably need to add `standard` to the enum [here](https://github.com/Shopify/ruby-lsp/blob/85b9e29d24c4eaed986a140aead82e8a436d3aad/vscode/package.json#L273). But the extension shouldn't really have to know about specific addons, so we probably need to re-think this approach.