datafusion-comet icon indicating copy to clipboard operation
datafusion-comet copied to clipboard

feat: Add support for BuildRight

Open andygrove opened this issue 1 year ago • 2 comments

What is the problem the feature request solves?

We are unable to run a number of TPC-H natively due to the error BuildRight is not supported. The queries affected include q2, q9, q10, q11, and q16.

See code in QueryPlanSerde.

if (join.buildSide == BuildRight) {
  // DataFusion HashJoin assumes build side is always left.
  // TODO: support BuildRight
  withInfo(join, "BuildRight is not supported")
  return None
}

Describe the potential solution

No response

Additional context

No response

andygrove avatar May 06 '24 19:05 andygrove

Related issue in DataFusion: https://github.com/apache/datafusion/issues/9603

andygrove avatar May 06 '24 21:05 andygrove

I will work on this at DataFusion.

viirya avatar May 14 '24 19:05 viirya