Andy Grove comments

Results 657 comments of


                                            Andy Grove

Pin ballista depedency to specific rev

@iajoiner fyi

feat: Add random row generator in data generator

LGTM overall. I think this is a good addition. I left a couple of small style suggestions.

Minor: Generate the supported Spark builtin expression list into MD file

This is very cool @comphead but it looks like it is not detecting any of the aggregate functions that we support?

feat: Implement Spark-compatible CAST from String to Date

> This PR is still in progress. I added support for String to Date32. > > * Spark supports dates in the format YYYY and YYYY-MM and DataFusion does not...

feat: Implement Spark-compatible CAST from String to Date

Thanks @vidyasankarv. I plan on carefully reviewing this later today.

feat: Implement Spark-compatible CAST from String to Date

There is one test failure with JDK 8 / Spark 3.2: ``` - cast StringType to DateType *** FAILED *** (349 milliseconds) "[CAST_INVALID_INPUT] The value '0' of the type "STRING"...

feat: Implement Spark-compatible CAST from String to Date

@vidyasankarv I would suggest that we skip the test for now when running against Spark 3.2 and file a follow on issue to fix 3.2 compatibility (this may not be...

feat: Implement Spark-compatible CAST from String to Date

> So I have pushed this build removing the fuzz test now to see if the build passes. So I might need some help in trying to identify the issue...

feat: Implement Spark-compatible CAST from String to Date

@vidyasankarv I am also very confused .. values that fail in the fuzz test work in the other test 🤔 I am debugging and will let you know when I...

feat: Implement Spark-compatible CAST from String to Date

@vidyasankarv I figured out what the issue is. I don't fully understand why, but when the fuzz test creates the DataFrame, the cast operation that gets performed is from a...