Andrew Toth

Results 200 comments of Andrew Toth
trafficstars

Call chunk(0) on the request object before adding the part.

> In my knowledge, the hook doesn't override the command itself, but the results of the command will pass also to the RPC command (before or after) run the command...

> I think they should get onto `rpc_command` hook. @ZmnSCPxj but as https://github.com/ElementsProject/lightning/issues/3709 says, they are not **user commands**, so shouldn't be passed into `rpc_command`. Since they are internal, I...

@ZmnSCPxj thanks for that insight. Investigating this further, it seems that commands sent from an external program or a plugin call `rpc_command`. When `lightningd` is sending directly to a plugin,...

Looking into this further, I don't think grouping the bitcoin backend commands with the `rpc_command` hook makes architectural sense. The `rpc_command` hook is triggered by commands coming into `lightningd` from...

I ended up creating a plugin that allows optionally compiling methods to replace bcli. This solves the issue for me, but it is unfortunately not built-in and bcli must be...

@stickies-v good catch thanks. I reran with a binary from bitcoincore.org and it added `zmq/getzmqnotifications.html`.

Hi @la841, this can be resolved by running `bitcoin-cli createwallet electrumpersonalserver true true "" false false true`.

Would it be worth separating this into a dependency bump PR instead? Then the taproot changes can be based off that.