Andrew Toth
Andrew Toth
Could we not just use `getblock` with `verbosity=3` to get the blocks with all input values?
Sorry can you elaborate on why https://github.com/casey/ord/pull/1357 was merged? What was the problem with skipping? I re-enabled it and tried it with p2p indexing. Because of headers sync it syncs...
Also, if we are going the route of calling `getrawtransaction` individually vs one `getblock verbosity=3`, then we should probably be using `async`. We can then hit the REST endpoint concurrently...
Ok I figured it out. Managed to sync by combining p2p and REST and reverting #1357 in 1:06. I think we can turn this back on :). Batching calls would...
With latest REST PR using hyper, myself on Linux and @so7ow on Mac synced in under an hour 🚀 https://github.com/casey/ord/issues/1648#issuecomment-1427946904.
Check out https://github.com/casey/ord/pull/1759. It still hasn't been explained why skipping transactions were removed, but that PR manages to sync efficiently without having all inputs.
For some more context, here is the PR that introduced `ReadRawBlockFromDisk` https://github.com/bitcoin/bitcoin/pull/13151. I see that this was attempted in https://github.com/bitcoin/bitcoin/pull/21319 as well.
@luke-jr I wasn't aware of #21319 until now, but I can't comment there because it's locked. If you want to reopen that I can review and remove the change to...
@TheCharlatan @RandyMcMillan rebased.
> Does testing the different branches involve something more than checking out the different branches (master and read-raw-block) on my local computer? @kashifs after checkout of each branch, you must...