Andrew Toth comments

Results 216 comments of


                                            Andrew Toth

trafficstars

rpc,rest,zmq: faster getblock, NotifyBlock and rest_block by reading raw block

@kashifs make sure to wait for the log line `initload thread exit` to be printed in the debug.log file when restarting bitcoind before running the benchmarks. For RPC, does the...

rpc,rest,zmq: faster getblock, NotifyBlock and rest_block by reading raw block

@furszy @TheCharlatan updated with both your suggestions, thanks!

During IBD, prune as much as possible until we get close to where we will eventually keep blocks

ACK d298ff8b62b2624ed390c8a2f905c888ffc956ff Ran benchmark with hyperfine: ``` hyperfine --show-output --parameter-list commit 96ec3b67a7a7f968d002e13d6fc227f69b7f07d7,d298ff8b62b2624ed390c8a2f905c888ffc956ff --setup 'git checkout {commit} && make -j$(nproc) src/bitcoind' --prepare 'sync; sudo /sbin/sysctl vm.drop_caches=3; rm -r /home/user/.bitcoin/blocks /home/user/.bitcoin/chainstate' -M...

Allow rpc_user and rpc_pass in config file

> rpcuser and rpcpassword will soon be deprecated. They will not be deprecated from use in *clients*. The deprecation refers to using bare `rpcuser/rpcpassword` in favor of generating an `rpcauth`...

Allow rpc_user and rpc_pass in config file

Two small nits but otherwise LGTM.

Use p2p for fetching blocks from bitcoind instead of rpc

Using REST is also a more suitable interface for this application than RPC. It requires no authentication and can transmit blocks in binary form. It also does not have to...

Electrum protocol support

Unless I'm mistaken, I don't think the electrum protocol is suitable for this type of application. `ord` needs to process all transactions of all blocks to index sats. Electrum is...

Export descriptor

This can be done with `bitcoin-cli -rpcwallet="ord" listdescriptors`.

Use p2p to fetch blocks and headers

Might fix issues related to https://github.com/casey/ord/issues/1377, since those look like the RPC threads are falling over from too many requests. I haven't fully groked the indexing logic for fetching raw...

Use p2p to fetch blocks and headers

Thanks @casey. This will make syncing faster even when skipping txs, since it fetches headers 2k at a time instead of incrementally. 1. Sorry for the REST tangent, that can...