Andrew Toth

Is there any update on this? I would like to help out if possible.

Ok, I will get started on a TaggedHash module. Leave that with me. I have some general thoughts on how we should approach this. I think making big changes before...

But that would make https://github.com/bitcoinjs/bitcoinjs-lib/blob/master/ts_src/transaction_builder.ts#L231 no longer just work with taproot, which is the key benefit in my view.

Ok it would be better than nothing if users of v5 can do `txBuilder.addOutput(baddress.bech32mToOutputScript(taproot_address), value)` instead of having no way to decode the new addresses.

@junderw here's the TaggedHash module if you want to pull it into BitcoinJs https://github.com/andrewtoth/tagged-hash.

It can be optimized by saving the mid state after hashing the prefix. I left an issue comment https://github.com/crypto-browserify/sha.js/issues/70. If it's worth it we can implement our own mid state...

I don't think #26316 is necessary anymore. We can simply remove files that are still on disk like in https://github.com/bitcoin/bitcoin/pull/26533.

> Can someone add a "needs benchmark" label? What kind of benchmark would be appropriate here? AFAICT message processing is done on a single thread, so this patch wouldn't speed...

I wrote a tool to allow benchmarking the affected code paths https://github.com/andrewtoth/spam_block_reqs. I ran it on block 768022 using 5000 requests for each of the four paths on both this...

Moved all whitespace only scope changes to separate commit to make it easier to review.