Andrew Toth

There are a few strategies to speed this up on the client side instead: - Fetch blocks concurrently - Fetch blocks in parallel - Fetch blocks in batch requests -...

@ismaelsadeeq nice find! I wonder, could you also benchmark [batch requests](https://www.jsonrpc.org/specification#batch)? Sending a single request that contains `rpcthread` number of `getblock` requests, both sequentially and multithreaded on the client side?

crACK cb9be6729c4e27bf2d6d703c0d454a22cbcdb6e1 This simplifies the CCoinsCacheEntry interface, which was leaking the flags bitfield as an implementation detail. Now we don't have to worry about fuzzing that, and it will make...

re-crACK 9edbe5a48fe9a2c0d364882fcb7d44ae6aac6d24

> Surprised that CCoinsCacheEntry::m_next and m_prev were not nulled out before this PR This was brought up but I didn't change it https://github.com/bitcoin/bitcoin/pull/28280#discussion_r1687007975. It does seem cleaner nulling them though.

Code Review ACK 50cce20013c97e1257cb9f4c9319701a09b0a196 Only behavior change from last review seems to be the new check in `CheckAccessCoin`. I'm not sure why `inline`s needed to be dropped.

ACK 6c52d6ed8a5b3cdfff9b565c139e35b821647f6b Downloaded 27.1 tar and ran `./bitcoin-cli` and got the broken popup. Ran the command, ran `./bitcoin-cli` and got the help output. Ran into this issue before with other...

reACK 27709f51ee02ed4f8c9c7e1c25c6f16faa0ef08b

It seems in this approach the `m_batch_mutex` is held for the entirety of adding, which will cause lock contention. `Verify` is then a blocking call on the main thread, which...

@sedited @l0rinc thank you both for your reviews! I rebased and updated with your suggestions.