Andrew Savage

Note these changes are all already in feature/all-upstream-update, this is just a review for cleanliness. Nothing will be able to build yet as the update to //build is still in...

> Btw I'm getting a little bit confused on how are we using this branch feature/update-base vs feature/all-upstream-update. Is this just purely for reviewing all past code change in feature/all-upstream-update?...

It looks to me like //build is changing because an old repository state is being brought into the PR as a whole. Please ensure you're only changing what you mean...

> Updated the commits: removed change in file `starboard/win/shared/platform_configuration/BUILD.gn` @andrewsavage1 Changes in //build are required to locate Visual Studio tools correctly when build with native toolchain. There are many changes...

> To be addressed still here: > > ``` > [38.216 sec | 9822/15605 5781 remaining | 43.8/sec | j3] LINK ./base_unittests > FAILED: base_unittests > "python3" "../../build/toolchain/gcc_link_wrapper.py" --output="./base_unittests" --...

Hoping we can get this landed soon, it's giving our project a number of issues

This looks fine to me, but I'm confused by the title—what are "vc tools"? Are we just updating the visual studio version or is something more going on?

I'm worried about introducing a new starboard API for this—I was hoping to just have `base::Move` fail if we were moving a directory and otherwise basically just call `base::CopyFile` then...

> Weird that there are three expected to fail WPT tests timeouts and it only happens on gcc-6-3 and clang-3-9. @andrewsavage1 Do you happen to know what can be different...

Yes this is obsolete