cobalt icon indicating copy to clipboard operation
cobalt copied to clipboard

Starboardize base

Open andrewsavage1 opened this issue 1 year ago • 3 comments

b/298237511

andrewsavage1 avatar Jan 08 '24 22:01 andrewsavage1

Note these changes are all already in feature/all-upstream-update, this is just a review for cleanliness. Nothing will be able to build yet as the update to //build is still in progress in #2100

andrewsavage1 avatar Jan 08 '24 22:01 andrewsavage1

Btw I'm getting a little bit confused on how are we using this branch feature/update-base vs feature/all-upstream-update. Is this just purely for reviewing all past code change in feature/all-upstream-update?

sherryzy avatar Jan 09 '24 23:01 sherryzy

Btw I'm getting a little bit confused on how are we using this branch feature/update-base vs feature/all-upstream-update. Is this just purely for reviewing all past code change in feature/all-upstream-update?

More or less, yeah, I'm thinking of feature/all-upstream-update as a place where we can make more hacky changes that would need to be cleaned up before being merged into trunk, and feature/update-base as a staging ground to clean up those changes and prepare for the final merge into trunk

andrewsavage1 avatar Jan 12 '24 17:01 andrewsavage1

Is this obsolete / can close ?

kaidokert avatar May 30 '24 20:05 kaidokert

Yes this is obsolete

andrewsavage1 avatar May 30 '24 21:05 andrewsavage1