cobalt icon indicating copy to clipboard operation
cobalt copied to clipboard

Update msvc toolchain to v19.39

Open niranjanyardi opened this issue 1 year ago • 5 comments

b/325537546

niranjanyardi avatar Feb 28 '24 22:02 niranjanyardi

Datadog Report

Branch report: feature/update_msvc Commit report: 2987fa8 Test service: cobalt

:white_check_mark: 0 Failed, 29771 Passed, 1 Skipped, 12m 16.05s Wall Time

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 58.26%. Comparing base (307668a) to head (a644fe6).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2516   +/-   ##
=======================================
  Coverage   58.26%   58.26%           
=======================================
  Files        1795     1795           
  Lines       84862    84862           
=======================================
+ Hits        49441    49443    +2     
+ Misses      35421    35419    -2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 29 '24 07:02 codecov[bot]

This looks fine to me, but I'm confused by the title—what are "vc tools"? Are we just updating the visual studio version or is something more going on?

andrewsavage1 avatar Feb 29 '24 16:02 andrewsavage1

This looks fine to me, but I'm confused by the title—what are "vc tools"? Are we just updating the visual studio version or is something more going on?

ahh VC tools is the literal folder where the msvc compiler lives. So we are upgrading the toolchain for xbox, win32 and all win host platforms with this change. I can edit the description to state that. my bad ill mark this as a draft cl, i think you might have gotten added automatically.

niranjanyardi avatar Feb 29 '24 17:02 niranjanyardi

Datadog Report

Branch report: feature/update_msvc Commit report: a644fe6 Test service: cobalt

:white_check_mark: 0 Failed, 29823 Passed, 1 Skipped, 10m 51.21s Wall Time