cobalt icon indicating copy to clipboard operation
cobalt copied to clipboard

[XB1] Crashpad integration.

Open v-kryachko opened this issue 1 year ago • 6 comments

b/321046655

Change-Id: Ic3134a213a1b97db0a8ef5b82b94c181b9514c06

v-kryachko avatar Feb 13 '24 08:02 v-kryachko

Yes, right. This PR makes Crashpad client possible to build for UWP. And yes, I plan another PR(s) for getting the Crashpad handler executable building for xb1.

v-kryachko avatar Feb 19 '24 13:02 v-kryachko

It looks to me like //build is changing because an old repository state is being brought into the PR as a whole. Please ensure you're only changing what you mean to

andrewsavage1 avatar Feb 20 '24 18:02 andrewsavage1

Updated the commits: removed change in file starboard/win/shared/platform_configuration/BUILD.gn @andrewsavage1 Changes in //build are required to locate Visual Studio tools correctly when build with native toolchain.

v-kryachko avatar Feb 22 '24 15:02 v-kryachko

Updated the commits: removed change in file starboard/win/shared/platform_configuration/BUILD.gn @andrewsavage1 Changes in //build are required to locate Visual Studio tools correctly when build with native toolchain.

There are many changes to //build that look like they're just refactoring code, not changing anything functional in it. We want to keep changes to //build (which is upstream code) as minimal as possible, so please only make changes to it when it's absolutely necessary.

andrewsavage1 avatar Mar 19 '24 15:03 andrewsavage1

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 58.25%. Comparing base (7e6c766) to head (ed14da7). Report is 1 commits behind head on main.

:exclamation: Current head ed14da7 differs from pull request most recent head 0e35fe4. Consider uploading reports for the commit 0e35fe4 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2425      +/-   ##
==========================================
- Coverage   59.85%   58.25%   -1.60%     
==========================================
  Files        1830     1794      -36     
  Lines       88549    84889    -3660     
==========================================
- Hits        53002    49456    -3546     
+ Misses      35547    35433     -114     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 19 '24 16:03 codecov[bot]

@andrewsavage1 Most of changes to //build can be moved to somewhere else, say, in //starboard/build? I'll try.

v-kryachko avatar Mar 21 '24 09:03 v-kryachko

I believe the latest status is we've shelved this project, as there are blockers to getting crashpad to work properly on XB1. Going to close this PR.

gbournou avatar Apr 25 '24 00:04 gbournou