Alya Abbott
Alya Abbott
As requested in the PR template, please post screenshots of all your changes in the PR description. Before / after screenshots at the same screen width would be helpful here.
Thanks! I don't know if we need the left panel to be quite this wide, but maybe it's OK. Having the placeholder text in the right-side panel spill onto the...
@sahil839 Do you want to take a look at this one? I haven't tested, but maybe the next step is to check whether this is a good direction.
What if we (1) kept the + with the other buttons, as suggested above, and (2) left-aligned the buttons when they spill onto a second line, rather than keeping them...
I've never liked the sorting buttons very much, by the way -- I think it's quite hard to interpret them at a glance. A more standard approach would be to...
@Lalit3716 As noted in the PR template, please include still screenshots, in addition to any videos. I'd like to see screenshots from the left sidebar, both in light and dark...
Thanks! For the hover behavior, we don't want a tooltip. We just want the unread count to show up like it does in other streams when you hover anywhere on...
Thanks! The functionality is inconsistent when I test it. E.g., when I pin a muted stream, the counter reappears (which it should not), though later I saw it disappear again:...
@Lalit3716 Please post a comment when you've addressed @timabbott 's feedback above and have manually tested your work, and I'll do another testing pass then. Thanks!
> but I am now getting no 100% test coverage on node test need some help there Have you asked for help on CZO?