Alice Frosi
Alice Frosi
/label good-first-issue
/sig code-quality
/cc @xpivarc @jean-edouard maybe you have an idea what is going on here
@ShellyKa13 the code looks good to me. Do you think the functional test is necessary?
> @alicefr I was thinking If I should add functest or not, cause I do think the UT cover it pretty good.. I dont mind deleting it Yeah, I have...
> @alicefr I do think that there is a value in functest since in case of a change in behavior in k8s for example then this test can catch problematic...
@mhenriks , I created this PR as we discussed with @fabiand and add my self as approver for the group. Please, let me know if it is fine for you.
`virt-host-validate` definitely helps, in fact, we do suggest using it, but it might not be easy to install on the host. Have you encountered any issues using it your distribution?
/label good-first-issue