Alice Frosi
Alice Frosi
Luckily for me, the controversial functions with the named returned values have already been removed by https://github.com/kubevirt/kubevirt/pull/11698
@0xFelix @vasiliy-ul do you mind to have another look to this? The controversial functions with the name returned values have already been refactored and removed
/label good-first-issue
/sig code-quality
@mhenriks a part from a couple of small comment the code looks good to me One question, is it CDI that is setting the owner reference on the PVC for...
/approve /hold Holding to let you fix last comments
@cfilleke @jschintag please take into account that we'll need also CI integration. Please, take a look to the [kubevirtci](https://github.com/kubevirt/kubevirtci) and [project-infra](https://github.com/kubevirt/project-infra). The CI needs to be integrated in prow and...
> I am currently working on squashing all the commits into something more presentable, and i will also rebase it as part of that. If i don't run into errors...
@alromeros this is an API change and we might have problems with backward compatibility. Have we discussed this somewhere?
@alromeros then I'd like a lgtm from people that have requested this change. Could you please tag them here?