Alice Frosi

Results 488 comments of Alice Frosi

Update PR with 2 new interfaces for the multi store support. The unit test are passing locally. However, I needed to put a couple of AnyTimes(). So probably we want...

I'm using inline tables for the `storage_option` because they are correctly parsed with toml, but I'd like to rework that and use a custom type. The array of storage_driver and...

> I'm now wondering how it impacts performance. Maybe we can do the e2e tests where the main storage driver is the second or third in a list of storage...

> couple of nits, sorry I forgot to review yesterday! > > I find myself wondering if processesing the annotaiton on the pod level is the best route. this seems...

> > But the annotation needs to specify per pod and the admin doesn't know this. This is similar to what we do when we specify the runtime class on...

> > I need to find a solution for the image pulling. Right now, I don't where to find the runtime information during this phase :). > > it's a...

@haircommander @saschagrunert maybe you have again some good hints for me :). Currently, I need to loop over all the sandboxes to compare the sanbox name from the [PodSandboxConfig](https://github.com/cri-o/cri-o/blob/main/vendor/k8s.io/cri-api/pkg/apis/runtime/v1/api.pb.go#L6371) in...

hi @saschagrunert @haircommander , I want to implement some functional tests and I need to configure a second storage driver. So far, I tested it on my laptop using overlay...

I'm not sure how much this is complicated to put in place, but maybe we could add add an additional lane to the CI for testing the multi-storage with runtime...