Alice Frosi

Results 628 comments of Alice Frosi

@naiming-zededa great! Many thanks for your contribution, it will be great to be able to run kubevirt also in a containerized environment. I left a couple of comments. Please consider...

It looks good to me, just want to know @xpivarc's opinion about https://github.com/kubevirt/kubevirt/pull/9668/files#r1182161268 /lgtm

@naiming-zededa sorry for the late reply. Well, we need a green CI /retest-required

> rebased to the main again to see if the test can pass. Yes, usually this helps when there are issues unrelated to the PR like these. Now, you only...

@naiming-zededa I'm fine with the part that finds the right path for chroot. Maybe you could remove the part that overwrites the capabilities? I do understand that doesn't solve your...

I still think it is dangerous, if you manage to create that file then you basically activate the ability to bypass the permission checks. This just hides the problem and...

> > I still think it is dangerous, if you manage to create that file then you basically activate the ability to bypass the permission checks. > > This just...

A part from a question, the rest already looks very good, thanks!