Alice Frosi

Results 628 comments of Alice Frosi

/test pull-kubevirt-e2e-k8s-1.29-sig-compute

> Early return is a contentious practice, but I like it exactly because it reduces indentation level. > > As > > ``` > $ git grep ' \{10\}'|grep -v...

@vasiliy-ul you are right, however, this was done in response to one of the previous reviews: https://github.com/kubevirt/kubevirt/pull/11260#discussion_r1494465615 . Additionally, most of the returned values are the causes variables and we...

> I like the idea of reducing the nesting levels, and the code in general looks good. However, this PR also heavily refactors named return values. AFAIK this topic is...

> I personally do not have a strong opinion. Specifically, in this PR, some functions return just a single value of type `[]metav1.StatusCause`. Probably there is no much benefit in...