Alice Frosi
Alice Frosi
Does your host supprot kvm? You can check by installing and running [`virt-host-validate`](https://libvirt.org/manpages/virt-host-validate.html). Another possibility is to enable [software emulation](https://github.com/kubevirt/kubevirt/blob/main/docs/software-emulation.md).
@arsiesys could you please explain why cannot you add the new field in the sidecar hook? This is an API extension and for unsupported fields, you should be able to...
@arsiesys you are right, the fix is correct. I think the problem is that if the field doesn't exist in schema.go then when virt-launcher parses the xml into the kubevirt...
@dharmit the code looks good. Just a suggestion, I would split the commit in 2 part, one with the rearrangements of the variables and a second wit the new variables...
here https://github.com/kubevirt/kubevirt/pull/11272/commits/cf98f5ffe4df7e560242c707892efbaa0fafd513 you are changing the variables order and also adding the new image. It is a bit confusing. If you need to sort the variable I'd do in a...
/approve /hold Hold to let you fix the last comments, but the code looks good.
/unhold
Example of if statement simplification by using return early pattern: https://github.com/kubevirt/kubevirt/pull/11260
One please here, if you see places in the code, where we could apply these best-practices already, please create an issue and use the label `good-first-issue`. Like https://github.com/kubevirt/kubevirt/issues/11305. In this...