Antoine du Hamel
Antoine du Hamel
It's not immediately obvious why this change is needed now, did the WPT suite start using non-JSON files recently?
It looks like all the action items have been ticked off, closing as completed. Let's reopen if I missed something.
Seemingly related test failures: ``` [EXPECTED_FAILURE][FAIL] Getters and value conversions should happen in order until an exception is thrown. assert_array_equals: lengths differ, expected array ["Symbol.iterator", "length getter", "length valueOf", "0...
> not sure why you mention moderation team, they don't have permission Moderation team members are org Owner, and therefore have technically Write permission on the repo.
Note that if we restrict it to Releasers, it will make onboarding harder. Maybe a better workflow would be to have some automation that sends a Slack notification everytime someone...
@targos do you mean LTS-staging branches, or also non-LTS ones?
> > > not sure why you mention moderation team, they don't have permission > > > > > > Moderation team members are org Owner, and therefore have technically...
To repeat what I said https://github.com/nodejs/Release/issues/1004#issuecomment-2083115849, I'm not sure adding a rule won't add frictions to onboarding new releasers. My recommendation would be to instead enforce commit signatures, because it:...
@lpinca could you try https://github.com/nodejs/node/pull/47452/commits/ab23463bf5785ca1323922c3c5e6a2bdf09d21dd? I'm not able to reproduce the deadlock locally, so I can't confirm if it is effective.
No it's not, it's based on it but it's meant to fix the test failures.