Antoine du Hamel
Antoine du Hamel
IMO requiring TSC approval (whatever that means) is really not necessary, IMO the usual code review process is enough. If there are objections/lack of consensus, the TSC can get involved,...
> I assumed "the TSC is pinged and we operate by lazy consensus and not necessarily a vote". If that's the case, +1, but that seems to be better described...
> `import.meta` is a shared namespace and we need to be more careful with it, including outreach to groups like WinterCG Isn't that already what's happening with the current process?...
I'm going to say it explicitly: I'm -1 on requesting TSC approval for changes on `import.meta`. I think this is not a necessary change, and we should resist the TSC...
@GeoffreyBooth do you have any opinions on the guidelines I have drafted?
> declaring bundled dependencies as a prerequisite to inclusion in this new process Bundled dependencies are a prerequisite for working with Corepack, so it wouldn't be too bad to have...
> Since [nodejs/corepack#360](https://github.com/nodejs/corepack/pull/360), I believe that's what they do. I don’t think that’s what Tobias meant: running `npm i -g pkg` will also download pkg’s dependencies and run the `postInstall`...
/cc @nodejs/tsc
This needs a rebase. We might as well close this PR so the bot opens a new one
📦: https://ci-release.nodejs.org/job/iojs+release/10665/