Antoine du Hamel

Results 952 comments of Antoine du Hamel

Could you give an example of something that no longer works with the new behavior in #51292, with a link to this PR? That should give everyone who participated in...

Tests are failing on GHA, I don't think it makes sense to run Jenkins CI now

> * Is there a way to better detect flaky tests before landing them? IMO, the correct response to that would be automation. Our previous attempt was https://github.com/nodejs/node/pull/43954, which I...

Another thing that would help would be to mark on the Current release line as flaky all tests which have a corresponding open issue. That would greatly help with making...

> Assigning a handler to the socket's error event listener later is insufficient, for example assigning the handler from within the following code still results in crashes: > > ```ts...

Folks, please add the https://github.com/nodejs/node/labels/author%20ready label, otherwise those PRs simply get forgotten

Should we ping them so they can confirm the info?

Do you still want to push for this @mcollina?

Would landing https://github.com/nodejs/node/pull/58847 change something to the current discussion?

/cc @nodejs/tsc @nodejs/moderation