Antoine du Hamel

Results 948 comments of Antoine du Hamel

I think we should go with [undici](https://github.com/nodejs/undici): Node.js has started vendoring it in and plans on exposing its implementation of `fetch` and `FormData` as globals in Node.js 18.

> Another option might be to use the `fetch` api Note that Undici's fetch is only available for Node.js 16.8+, and we still want to support v14.20+.

Hi, thanks for the report. Indeed, as the end user, there's no way to disable the mirror mode, I confirm it's far from ideal when trying to use the back...

FWIW the bug is also reproducible on the 3.x branch: https://codesandbox.io/s/musing-blackwell-rpqhxr

> Could we keep the transloadit and textarea examples, but hide them? Easier to put them back asap then. Not really, what do you mean? They have a dependency on...

> Could we keep the transloadit and textarea examples We could (should?) try to re-write those examples instead of deleting them, since we're holding the 3.0.0 release for a few...

My opinion on this is we should keep existing `--fix` in pre-commit hooks, and even add it to the `.js` files once we have refactored all of them to ESM....

That would be true if we had no warnings, only errors. Currently it’s still very easy to commit something without realizing it’s forbidden only because the rule is behind a...

To clarify, it's not exactly related to ESM, it's more than if we are going to refactor (almost) all of our JS files to make them use ESM syntax, let's...

Hi, thanks for the report. The "no error in the console" part is quite intriguing. Do you know if that's specific to one browser in particular? Did you try to...