Antoine du Hamel

Results 948 comments of Antoine du Hamel

@guybedford > I do still think there might be confusion in the `package.json` if it will apply when loading a dependency. Note that the `package.json` field uses the wording "node...

I think this qualifies for "incorrect usage of Node.js internals". Thoughts @nodejs/fs?

> I'm very reluctant about adding this because I think it's a mistake to resume CI without looking at the failures, and if you are looking at the failures you...

> I just think the user experience would be better. Currently the user experience is to go to the Jenkins Web UI to check what are the failures, and if...

Or could the bundled Undici use the native one? @nodejs/undici

> What if in the next major version of Node, the root entrypoint is always an ESM script? A lot of async hooks tests start failing when the bootstrap is...

Can you try to run the following commands in your terminal: ```sh /bin/sh -c 'node -v' /bin/sh -c 'npm --version' /bin/sh -c 'yarn --version' ```

Note to self: before merging, ensure that `yarn build` works.