uppy icon indicating copy to clipboard operation
uppy copied to clipboard

Published 20 hours ago • verified publisher icon transloadit

@uppy/robodog: remove package

Open aduh95 opened this issue 1 year ago • 6 comments

This removes examples/transloadit and examples/transloadit-textarea because that's relying on Robodog. It'd be nice to have the "Remote Sources" examples landed first.

I haven't tested the website changes, but I have a bad feeling about this.

I'm keeping all the robodog-*.md files so the direct links still work.

aduh95 avatar Aug 03 '22 16:08 aduh95

Could we keep the transloadit and textarea examples, but hide them? Easier to put them back asap then.

arturi avatar Aug 03 '22 16:08 arturi

Could we keep the transloadit and textarea examples, but hide them? Easier to put them back asap then.

Not really, what do you mean? They have a dependency on Robodog, Yarn won't be able to resolve it. They're still on the 2.x branch if we need them.

aduh95 avatar Aug 03 '22 16:08 aduh95

Using this PR to rewrite the examples now.

arturi avatar Aug 04 '22 13:08 arturi

Updated, needs a local test of all of the examples, please @aduh95, this is an easy one to screw up.

arturi avatar Aug 05 '22 16:08 arturi

Could we keep the transloadit and textarea examples

We could (should?) try to re-write those examples instead of deleting them, since we're holding the 3.0.0 release for a few more days.

aduh95 avatar Aug 05 '22 22:08 aduh95

But that’s what I did? https://github.com/transloadit/uppy/pull/3946/files#diff-b9a6c3b2d50c22e037af96fcb0f6dadf88dfeed09b3b4b88d71ad2ed83e8c924

Ah, you mean the /examples, non-website.

arturi avatar Aug 05 '22 23:08 arturi