node
node copied to clipboard
Add timezone update workflow
Currently, this script checks the timezone version of the runner (instead it should be checking from elsewhere, I will check on how to do that). I haven't tested this by running an action yet.
Creating this PR to get early feedback
Edit 1 Just discovered node/tools/icu-data
, will get the data from there instead & update the PR
Edit 2 tested this action in my fork. Looks okay to me
Resolves 43134
Review requested:
- [ ] @nodejs/actions
What should be the frequency of the workflow? It currently is set to every Sunday. I think we should set it to run every day.
What should be the frequency of the workflow? It currently is set to every Sunday. I think we should set it to run every day.
We only release new versions of Node.js every two weeks or so, I don't think we'd get much by increasing the frequency (and the downsides would be more noise, and less overall available GHA runners).
Should we add a test? We can check the value of process.versions.tz
in the test, and whenever the workflow updates the ICU file, we will update the test as well. The test will serve two purposes
- test if the tz version is really updated
- A place in the codebase that clearly tells the tz version. Right now only after we build Nodejs & run it, we get to know the tz version.
Hey! I've read the original discussion in #43134 , and I was wondering if you might need any help?
I am also new to open source projects and I would very much like to learn how to contribute!
@NourABSH I’m waiting for additional feedback on this diff, but if you can find a better way to tackle this, then please feel free to create a new diff, I’ll close this one after you open yours.
Hi @srl295, you mentioned me in #43134 how can i help in this issue
Hi @srl295, you mentioned me in #43134 how can i help in this issue
perhaps by reviewing or even testing the code in this PR?
is this still open
is this project assigned to anyone
@yumaoka do you have any comments on this approach?
FYI @nodejs/i18n-api
What should be the frequency of the workflow? It currently is set to every Sunday. I think we should set it to run every day.
time zone releases aren't every day. If it's weekly it should cache the icudata repo
Landed in https://github.com/nodejs/node/commit/85b46e1cab0f91eb87ff30f14bee0b456a63c83b, thanks for the contribution 🎉
Please ping me if you have questions on it !