Axel Donath

Results 231 comments of Axel Donath

Thanks @mgeier for the response! I'm actually interested to work in this, however I have minimal knowledge on implementing sphinx extensions. The first part on parsing and checking the source...

Thanks a lot @mgeier, this sounds doable! I might come up with a first implementation next week...

Thanks @mgeier for there review! I addressed all of your comments, please let me know if you have further ones. Currently it seems the latex build fails, I'm not sure...

@mgeier Do you have time to look at this again? Thanks!

Time is now too short to test this for the v0.19 release. Sorry for that @Bultako, but we will come back to this for v1.0. I'll adapt the milestone now.

@registerrier I also noticed that we call the returned map in the `LiMaMapEstimator` "significance", I guess for correctnes we should maybe change to `ts` and `sqrt_ts` as well. This also...

Yes, I think there are two options: - We agree on a definition of `significance`, document it and compute it internally - We just work with `ts` internally and document...

By now there is already the following example: https://docs.gammapy.org/0.18.2/stats/index.html#estimating-ts

For v1.0 this remains a docs example here: https://docs.gammapy.org/dev/user-guide/stats/index.html#estimating-ts