Axel Donath

Results 231 comments of Axel Donath

Thanks @AtreyeeS, I agree. I just changed the title and will re-open now...

> I don't think this class represents a map of kernels but simply a map of non-isotropic PSF. @registerrier Your description would imply that the `.get_psf_kernel()` does the reprojection on...

@registerrier Following your understanding of the asymmetric PSF map, we would maybe not need any `PSFKernelMap` at all, right? Just making sure the current `PSFMap` does not hard-code the dependency...

Just taking the thought a bit further, maybe it still make sense to have both, a `PSFKernelMap` and a `PSFMap` like so: ```python class PSFMap(IRFMap): """Implements all common functionality, should...

This not going to be part of the v1.0 documentation, but we optionally introduce a recipe for it. Will relabel now...

I think having a convenience method to load data from an observation into memory might be useful here. So either: - `Observation.to_in_memory()` or similar - `data_store.obs(12346, in_memory=True)`

Here is another simple implementatio, that I have used in the past: ```python3 def add_cbar(im, ax, fig): """Add cbar to a given axis and figure""" bbox = ax.get_position() loright =...

I'll try to add this before v1.0...

This PR does not have a milestone, @registerrier will this be ready for v1.0?

@LauraOlivera I remember you had some interest in this in the past. Feel free to un-assign if you are not interested or don't have time...