Axel Donath

Results 231 comments of Axel Donath

Thanks @aaguasca! All temporal models are documented in detail in the model gallery here: https://github.com/gammapy/gammapy/tree/master/examples/models/temporal And in the actual API docs, we just define a reference to the model gallery...

I think so far we haven't really seen any analysis issues to this and the approximation of using the mid of run time was mostly good enough. But I agree...

Thanks @bkhelifi! Even I was not aware of this, I agree it would be good to make this a bit more visible...

The basic answer here is, that we would like to have it, but it's not supported completely and uniformly yet. I started to work on this in #1685 and #1757....

The remaining action item here is to do the same change as in #2344 for `HpxGeom`.

Could be a address as part of `gammapy.maps` refactoring for v2.0

Thanks @AtreyeeS! Indeed I think norm spectral models are not supported...I guess we should raise a meaningful error for now?

On closer inspection all information is actually there: - We have `flux_points.reference_model`, which also contains the `TemplateSpatialModel` - The `flux_points.dnde_ref` (and `flux_ref` etc.) would need to be changed to take...

@QRemy This issue is assigned to you. Do you have time to open a PR to raise and error, that `NormSpecralModel` objects are not supported for now?