Axel Donath

Results 231 comments of Axel Donath

Broken links are fixed by now. For the Estimator notebook we have different issue #3716. I'll close this issue now.

Yes, for ID 23592 the offset is actually larger than 2.5 deg and thus the effective area is zero. That's why the option "aeff-max" does not work. I'm not sure...

> position will take precedence over fixed_offset but this is not clearly stated. This is not correct: https://github.com/gammapy/gammapy/blob/master/gammapy/makers/safe.py#L157 > I assume a safe behavior would be to make the Maker...

Addressed in #3987.

Thanks @registerrier! I think the performance overhead should go away, once one uses larger index arrays. Might be good to double check. In general making the indexing independent of the...

Here is a notebook with some indexing performance checks: https://nbviewer.jupyter.org/github/mdmueller/astropy-notebooks/blob/master/table/indexing-profiling.ipynb

> can we decide on the content of the meta table for 1.0 Honestly, I think we can't, not in the given time frame. The topic is too big and...

Conclusion from the dev call: - The dataset name should be serialized with the FITS file in the header of the primary HDU. The `.meta_table` is currently fully optional, while...