Axel Donath

Results 231 comments of Axel Donath

Thanks @bkhelifi! I think there is still a bug in our workflow. The file I actually updated in https://github.com/gammapy/gammapy/pull/4013, which is completely unrelated...

Thanks @mcerruti, indeed this is a very valid use case. Technically this is rather simple to implement as and extension to the `LightCurveEstimator`, but it requires a bit of work...

I actually want to start working on this issue this week on a lower level. So the idea would be to make `SpectrumDataset.model` and `SpectrumDatasetOnOff.model` a `SkyModels` object as well....

So the YAML would look like: ``` components: - name: crab type: SkyModel spatial: type: NoneSpatialModel spectral: type: PowerLawSpectralModel parameters: - name: amplitude value: 1.0e-12 unit: cm-2 s-1 TeV-1 -...

After #2620 and #2619, the spatial model in the `SkyModel` is optional on serialisation and evaluation. The functionality is shown in the second level API, where we now use `model...

@Bultako In #2817, I have modified the analysis 1d test to read a YAML file that specifies the spectral model only. I can confirm it works. The remaining action item...

@registerrier FYI: in https://github.com/gammapy/gammapy/commit/ac9ce360f43ee7b7b633a36997c97778b9c53136, I changed the implementation to use the `..glossary::` sphinx directive. This allows to use `:term:` to reference entries in the glossary. See https://www.sphinx-doc.org/en/master/usage/restructuredtext/directives.html#glossary

@registerrier Removing e.g. `gammapy/utils/coordinates` and refactoring the code where it is used. However I'll relabel the issue now...