Adam Scott

Results 211 comments of Adam Scott

I added a new pass, `clang-format-glsl`, that processes .glsl files only using `.clang-format-glsl`. That file is composed from the same rules as `.clang-format`, but with the `RemoveSemicolon` rule turned off....

Can't really do, the rules are applied from the root to the files below.

> > I still wonder how we can compile this using the C++17 standard. 🤔 > > https://github.com/godotengine/godot/blob/6732a0fd867f40751c53f8ed7a3a15bf1b45323f/drivers/metal/rendering_device_driver_metal.mm#L1035-L1043 > > > > cc. @stuartcarnie > > @adamscott that is in...

I'm on it. This PR slipped between my cracks, sorry!

Talked about in a GDScript meeting. This kind of feature would nicely fit in a 4.4 release. We need to review it first, though. cc. @HolonProduction @vnen

@sbc100 I completely rewrote my PR from the ground up. I added a test, changed the fix, and I updated the PR description.

@sbc100 ci/circleci seems to break because `emcc: error: LLVM version for clang executable "/root/emsdk/upstream/bin/clang" appears incorrect (seeing "21.0", expected "20") [-Wversion-check] [-Werror]`

> I apparently don't know how to do proper code blocks on GitHub either, but I'm hoping you can make sense of where I was trying to do them. You...

@TheFoxKnocks Next time, please join an MRP to the issue.