Ava Chow
Ava Chow
> rfm I don't think so. This PR lacks (conceptual) review from senior contributors. It's also mostly a stylistic change which we generally do not care about doing. This also...
ACK 0ac969cddfdba52f7947e9b140ef36e2b19c2c41
> What would we need to do differently before we open a PR? Just building the site and committing the result. Can be done easily with `make`.
> Can you write a doc for it, e.g. in CONTRIBUTING.md? Done. Also rebased.
> Am I understanding correctly that if I checkout this PR, and run `make build`, there should be no diff generated? As that currently isn't the case. It's supposed to....
I think the non-determinism was because of sort order for posts made on the same date. Latest push should fix that.
> > I've also changed the PSBT BIP to use 33 byte plain aggregate pubkeys rather than xonly. > > It would be helpful to document the reasoning in the...
I've made a minor change with the descriptors regarding sorting. Keys in a `musig()` can be specified in any order, but will be sorted prior to aggregation, similar to `sortedmulti()`....
> What is the rationale for this change? I had a discussion involving @jonasnick and @sipa about this. Since BIP 327 suggests to do sorting, we decided it made sense...
> In #1434 it was [mentioned](https://github.com/bitcoin/bips/pull/1434#issuecomment-2088885809) that this proposal may conflict with the way PSBT is used by an existing implementation. Has there been any communication to reconcile that? I've...